Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1] zed: Fix zed ASSERT on slot power cycle #15092

Merged
merged 1 commit into from
Jul 24, 2023
Merged

[2.1] zed: Fix zed ASSERT on slot power cycle #15092

merged 1 commit into from
Jul 24, 2023

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Trivial ZED backport.

Description

We would see zed assert on one of our systems if we powered off a slot. Further examination showed zfs_retire_recv() was reporting a GUID of 0, which in turn would return a NULL nvlist. Add in a check for a zero GUID.

How Has This Been Tested?

Clean backport from master.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter @behlendorf
zed: Fix zed ASSERT on slot power cycle
9588581 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tony Hutter <[email protected]>
Closes openzfs#15084
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 21, 2023
@behlendorf behlendorf changed the title zed: Fix zed ASSERT on slot power cycle [2.1] zed: Fix zed ASSERT on slot power cycle Jul 21, 2023
@behlendorf behlendorf merged commit 846a4cc into openzfs:zfs-2.1.13-staging Jul 24, 2023
5 checks passed
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @tonyhutter